Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions #113

Closed
zakv opened this issue Aug 31, 2021 · 1 comment · Fixed by #114
Closed

Update install instructions #113

zakv opened this issue Aug 31, 2021 · 1 comment · Fixed by #114

Comments

@zakv
Copy link
Collaborator

zakv commented Aug 31, 2021

Right now the docs suggest running python setup.py develop to perform an editable install, but the better approach is to use pip install -e <path_to_mloop>. See e.g. https://stackoverflow.com/questions/30306099/pip-install-editable-vs-python-setup-py-develop.

Similarly, the suggested testing command at the moment is python setup.py test which is now a deprecated approach (see pypa/setuptools#1684, pytest-dev/pytest#5534, pytest-dev/pytest#5546). The command pytest runs the tests, so that should be the suggested method.

@zakv
Copy link
Collaborator Author

zakv commented Aug 31, 2021

This issue came up in #111.

@zakv zakv closed this as completed in #114 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant