Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order comparison results by baseline similar to benchmark-ips #26

Open
technicalpickles opened this issue Aug 31, 2023 · 2 comments · May be fixed by #28
Open

Order comparison results by baseline similar to benchmark-ips #26

technicalpickles opened this issue Aug 31, 2023 · 2 comments · May be fixed by #28

Comments

@technicalpickles
Copy link

When I'm writing benchmarks, I almost always want to compare against an existing result. benchmark-ips supports this with:

Benchmark.ips do |x|
  # ...
  x.compare! order: :baseline
end

I'd love to have something similar for benchmark-memory, so that the the comparison values (ie 1.54x) is relative to the first defined report.
@michaelherold
Copy link
Owner

Yes, this is a great idea. I'd be happy to review a PR if you want to put one together. Otherwise, I will do this the next time I have some free programming time.

It should have the same API as benchmark-ips, as you noted.

@michaelherold michaelherold linked a pull request Oct 13, 2023 that will close this issue
Open
@michaelherold
Copy link
Owner

@technicalpickles, would you give the branch a try before I merge and release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow comparison against a baseline michaelherold/benchmark-memory
2 participants
@technicalpickles @michaelherold