Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate MAC_ARM64 releases to SDKMAN! #619

Open
ali-ince opened this issue Sep 7, 2022 · 6 comments
Open

Automate MAC_ARM64 releases to SDKMAN! #619

ali-ince opened this issue Sep 7, 2022 · 6 comments
Labels

Comments

@ali-ince
Copy link

ali-ince commented Sep 7, 2022

I am on an M1 Macbook and when I try to install neo4j-migrations through sdkman, I get the following error;

❯ sdk install neo4jmigrations

Stop! neo4jmigrations 1.10.1 is not available. Possible causes:
 * 1.10.1 is an invalid version
 * neo4jmigrations binaries are incompatible with your platform
 * neo4jmigrations has not been released yet

Tip: see all available versions for your platform:

  $ sdk list neo4jmigrations

The command sdk list neo4jmigrations outputs only the following version, which I am able to install explicitly.

================================================================================
Available Neo4jmigrations Versions
================================================================================
     1.5.1

Any pointers/workarounds would be greatly appreciated :)

@michael-simons michael-simons changed the title only 1.5.1 is available on sdkman Automate MAC_ARM64 releases to SDKMAN! Sep 8, 2022
@michael-simons
Copy link
Owner

Hey @ali-ince Thanks for the ticket!
GitHub does not yet provide MacARM runners and I haven't succeeded on setting up one.

I have uploaded an ARM binary for the 1.10.1 to the release and also updated SDKMan! manually build on a private machine.

Please give me feedback if this works for you but keep the ticket open. Thank you!

@michael-simons michael-simons added enhancement New feature or request build and removed enhancement New feature or request labels Sep 8, 2022
@ali-ince
Copy link
Author

ali-ince commented Sep 8, 2022

Thanks for looking into it, but I believe there is a problem with the uploaded version, as it just quits with a killed message;

❯ neo4j-migrations
[1]    27080 killed     neo4j-migrations

I think we'll need to wait until github actions support the M1 arch.

@michael-simons
Copy link
Owner

michael-simons commented Sep 8, 2022

The compressor I use does not work, I can reproduce this.
And while trying to fix the release on SDK Man, I completely broke it.

Scratch that @ali-ince, I realized what I did wrong.
A reinstall of 1.10.1 will work now.

The binary I put up on Github works now.

@michael-simons
Copy link
Owner

@all-contributors add @ali-ince for usertesting

@allcontributors
Copy link
Contributor

@michael-simons

I've put up a pull request to add @ali-ince! 🎉

@michael-simons
Copy link
Owner

Linux ARM64 binaries are now published automatically. Same approach with a custom runner can be used eventually for Mac ARM binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants