Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording of migrations with unmatched assumptions. #557

Open
michael-simons opened this issue Jul 13, 2022 · 0 comments
Open

Recording of migrations with unmatched assumptions. #557

michael-simons opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@michael-simons
Copy link
Owner

We should reconsider the fact that we don't record migrations with unmatched assumptions. Right now, they are skipped as a whole in the chain and are not recorded. That leads to issues:

Skipping a migration based on a version (version >= x, migrations no longer applied)

Given 3 migrations on version < x
Chain will be 1,2,3
Database will be upgrade to x
Chain will be 1,3, validation will fail due to unexpected migration (3 in this case, already being recorded)

It would have been prevented by having an "empty" migration for version x.

Migrations suddenly applied

Same, but chains switched.

cc @meistermeier @ali-ince

@michael-simons michael-simons added the enhancement New feature or request label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant