Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go version declared in go.mod #73

Merged
merged 1 commit into from May 13, 2020

Conversation

x1nchen
Copy link
Contributor

@x1nchen x1nchen commented May 13, 2020

Function handshake.DefaultCertificateSelector uses the field
*tls.ClientHelloInfo.SupportsCertificate which only supported in go 1.14

Fucntion handshake.DefaultCertificateSelector use the field
`*tls.ClientHelloInfo.SupportsCertificate` which only supported in go 1.14
@x1nchen
Copy link
Contributor Author

x1nchen commented May 13, 2020

ref: crypto/tls: implement (*ClientHelloInfo).SupportsCertificate · golang/go@dd01738: golang/go@dd01738

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point -- thanks!

@mholt mholt merged commit 69af6a5 into caddyserver:master May 13, 2020
@x1nchen
Copy link
Contributor Author

x1nchen commented May 13, 2020

emmm, I suppose we'd better add some expaination to document why this module is only supported by go 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants