Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github actions for CI (#297) #298

Merged
merged 1 commit into from Oct 30, 2021
Merged

Add github actions for CI (#297) #298

merged 1 commit into from Oct 30, 2021

Conversation

iotanbo
Copy link
Contributor

@iotanbo iotanbo commented Oct 29, 2021

This PR adds Github Actions support to the project, related issue is #297.

mholt
mholt approved these changes Oct 29, 2021
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. Can we remove the azure CI while we're at it?

@iotanbo
Copy link
Contributor Author

iotanbo commented Oct 30, 2021

Removed azure-pipelines.yml and the badge from README.md.
If there are any references to azure that I omitted, let me know.

mholt
mholt approved these changes Oct 30, 2021
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! I had been wanting to get around to this but, life....

@mholt mholt merged commit cc194d2 into mholt:master Oct 30, 2021
@iotanbo iotanbo deleted the feature-#297 branch October 30, 2021 17:42
@iotanbo
Copy link
Contributor Author

iotanbo commented Oct 30, 2021

Cool, btw what do you think about a new patch release?

@mholt
Copy link
Owner

mholt commented Nov 1, 2021

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iotanbo @mholt