Bugfix issue#222 #296
Merged
Bugfix issue#222 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
reviewed
Oct 22, 2021
kolbycrouch
added a commit
to kolbycrouch/archiver
that referenced
this pull request
Oct 23, 2021
iotanbo
force-pushed
the
bugfix-issue#222
branch
from
d0940d7
to
7824911
Compare
|
Thanks for the reply. I reverted all changes related to CI. |
|
Noticed that this pull request solves same issue as https://github.com/mholt/archiver/pull/201/files and https://github.com/mholt/archiver/pull/230/files, the difference is that this one does it for both .zip and .tar archives while the other only for .tar. |
mholt
requested changes
Oct 28, 2021
archiver.go
Outdated
| @@ -125,6 +125,9 @@ type File struct { | |||
| type FileInfo struct { | |||
| os.FileInfo | |||
| CustomName string | |||
| // Stores path to the source. | |||
| // Used when reading a symlink. | |||
| SrcPath string | |||
There was a problem hiding this comment.
Suggested change
| SrcPath string | |
| SourcePath string |
Generally I prefer to spell out words if it's not cumbersome, and I think we can in this case, since "source" is a pretty short word.
iotanbo
force-pushed
the
bugfix-issue#222
branch
from
7824911
to
78cca10
Compare
mholt
approved these changes
Oct 28, 2021
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
When writing symlinks to .zip or .tar archive, Write method uses the archive path instead of real path to access a symlink on the file system. This causes errors like
readlink: readlink path/to/some/file: no such file or directory.Bug fix:
SrcPathfield toarchiver.FileInfoso that Write method can use it to read the symlink.