Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papa.parse(): comments option breaks for quoted cells #1031

Open
NamesMT opened this issue Dec 3, 2023 · 1 comment
Open

Papa.parse(): comments option breaks for quoted cells #1031

NamesMT opened this issue Dec 3, 2023 · 1 comment

Comments

@NamesMT
Copy link

NamesMT commented Dec 3, 2023

If we force quotes, or the row is automatically quoted, comments doesn't work as expected.

Example:

Take this value as the first cell data of a row.

# Comment lines should have the
first column start with "#" to
avoid parsing error

Because of the usage of newline and quotes, the example cell data above is automatically quoted.
With the config: comments: "#", we would expect this row to be ignored, however, it's still included in the parsed output.

I have tried configuring every possible options and variant of newline and delimeter for both unparse (to create a test csvString data) and parse, but I've hit a dead end.

@pokoli
Copy link
Collaborator

pokoli commented Dec 4, 2023

Could you please provide a simple sample code to reproduce your issue?
This way we can include on our test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants