Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity about death_handers #703

Open
schwern opened this issue Apr 12, 2022 · 0 comments
Open

Ambiguity about death_handers #703

schwern opened this issue Apr 12, 2022 · 0 comments

Comments

@schwern
Copy link

schwern commented Apr 12, 2022

The README says...

Starting in v5.1, Sidekiq can also fire a global callback when a job dies: In version 7, this is handled automatically for you. You don't need to add a death handler, if you configure v7 like in Add the middleware you don't have to worry about the below.

Is "In version 7" referring to version 7 of sidekiq or sidekiq-unique-jobs? In other words, if I'm using sidekiq >= 5.1 and sidekiq-unique-jobs >= 7 I do not need a death_handler?

if that's the case, that it's only for older versions of sidekiq-unique-jobs, I'd suggest removing it from the README; it's just confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants