Add 'Delete All' button to web UI #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2019 20:07
Can somebody silence this CodeClimate error? 🙂 |
mhenrixon
reviewed
Feb 8, 2019
|
@mhenrixon added integration test for |
|
Thanks @john-denisov, I fixed the style violations in #370 and will merge that as soon as the build passes. |
|
Closed with #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #357
I had to to put delete_all action above show action so it would get matched first.
I could have put it as last action if I used HTTP method POST instead of GET. But I assume that there's a reason why POST is not used for regular
deleteform. So I followed the same approach.Or we can leave it like that. Maybe it's just me who is used to order all actions by where they belong in
CRUDacronym 😅