Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low quality piece of shit #360

Closed
mainameiz opened this issue Dec 18, 2018 · 7 comments
Closed

Low quality piece of shit #360

mainameiz opened this issue Dec 18, 2018 · 7 comments

Comments

@mainameiz
Copy link

mainameiz commented Dec 18, 2018

I just started an upgrade from v3 to latest version in my project and can't find anything useful from changelog or readme.


From Changelog

v4.0.0
- 100% breaking changes

What was broken between v3 and v4? What was changed?


Which parameters are passed to unique_args proc/method, just job arguments or worker_class+queue_name+args

Here unique_args method accepts name, id and options. What does it mean? Which name? Which id? What options?

  def self.unique_args(name, id, options)
    [ name, options[:type] ]
  end

But when you use unique_args in real project, it accepts only one parameter - job arguments.

Is it changed between v3 and v4 or not?


unique: true was removed, but with which mode it must be replaced?

@mainameiz
Copy link
Author

Could you follow suggestions about changelog written here and improve the readme file?

@henrik
Copy link

henrik commented Jan 3, 2019

@mainameiz Wow, that's a very rude issue title. May I suggest you rephrase it?

Please realise that maintainers don't owe you anything. If I was the maintainer, I would go out of my way not to help someone if they expressed themselves this way.

@jchatel
Copy link

jchatel commented Jan 14, 2019

Nice, definitely someone with anger issues. But he probably didn't understand what it meant since he wrote Peace instead of Piece 🤣

@ivandenysov
Copy link

ivandenysov commented Feb 7, 2019

@mainameiz You need to have a piece of mind :trollface:

@mainameiz
Copy link
Author

Ok guys, sorry, I was in rage when I wrote it.
But I really think that this gem has a poor quality and code. I tried to update this gem through several major versions (from 3.x version to 6x) And there was no way to check what was changed. The only way was to read all the code and commits made for a years.

@richkettle
Copy link

You could have published that and saved the next person. But I wouldn't expect that from someone with the title you gave.

@mainameiz mainameiz changed the title Low quality peace of shit Low quality piece of shit Jul 7, 2020
@henrik
Copy link

henrik commented Jul 7, 2020

😂 Glad that offensive typo was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants