Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough has been deprecated and will be removed in redis-namespace 2.0 #338

Closed
everaldo opened this issue Oct 31, 2018 · 6 comments
Closed

Comments

@everaldo
Copy link

Please, update the gem to remove this warning

Passing 'script' command to redis as is; administrative commands cannot be effectively namespaced and should be called on the redis connection directly; passthrough has been deprecated and will be removed in redis-namespace 2.0 (at $HOME/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/sidekiq-unique-jobs-6.0.6/lib/sidekiq_unique_jobs/scripts.rb:57:in `script_sha')

@mathieujobin
Copy link

I recently noticed a similar warning got removed after PR #275 got merged.
maybe the method script_sha needs similar update

hope this helps

@pacoguzman
Copy link
Contributor

I've just reached this problem through:

redis-namespace 1.5.2

Passing 'time' command to redis as is; blind passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-unique-jobs-6.0.6/lib/sidekiq_unique_jobs/connection.rb:18:in `block in redis')

After upgrade to redis-namespace 1.5.3

Passing 'script' command to redis as is; administrative commands cannot be effectively namespaced and should be called on the redis connection directly; passthrough has been deprecated and will be removed in redis-namespace 2.0 (at /.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-unique-jobs-6.0.6/lib/sidekiq_unique_jobs/scripts.rb:57:in `script_sha')

So based on the last warning message, I think it cannot be easily solved on redis-namespace as it seems it cannot be effectively namespaced, I wouldn't expect redis-namespace will remove that warning so I think it needs to be addressed on sidekiq-unique-jobs, I'm already working on this to provide a solution.

@mathieujobin
Copy link

I have yet to not fully test it, but I patched v5.0.10 version of this gem for this using changes found in #275
if you want to play with it https://github.com/mathieujobin/sidekiq-unique-jobs/tree/v5.0.10-namespace

all tests are passing on travis

@mhenrixon
Copy link
Owner

You'd have to give me more information for me to help you on this @pacoguzman @everaldo. That line doesn't provide enough information for me to act.

@everaldo
Copy link
Author

I'm sorry, @mhenrixon , but it's been a long time since I don't work on this project anymore. But I believe this bug (warning) happens in any project using the gem.

@mhenrixon
Copy link
Owner

mhenrixon commented Apr 13, 2019

Well since Mike won't support redis-namespace neither will I -> sidekiq/sidekiq#3366 (comment)

Read this for how to migrate away from namespacing http://www.mikeperham.com/2017/04/10/migrating-from-redis-namespace/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants