Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Client Speedup #775

Open
ghost opened this issue Nov 17, 2003 · 1 comment · May be fixed by #2230
Open

Minor Client Speedup #775

ghost opened this issue Nov 17, 2003 · 1 comment · May be fixed by #2230
Labels
auto-migrated com enhancement sourceforge

Comments

@ghost
Copy link

ghost commented Nov 17, 2003

In CDispatch._ApplyTypes_ (win32com.client.dispatch)
i get a small (but worthwhile) speed improvement if I
replace (during lots of ADO recordset operations):

result = self._oleobj_.InvokeTypes(*(dispid, LCID,
wFlags, retType, argTypes) + args)

With:

result = self._oleobj_.InvokeTypes(dispid, LCID, wFlags,
retType, argTypes, *args)

I think they are functionally equivalent.

Sorry I haven't worked out how to create this as a
patch.

Cheers,
Giles

Reported by: gilesbrown

Original Ticket: "pywin32/feature-requests/16":https://sourceforge.net/p/pywin32/feature-requests/16
@ghost ghost assigned ghost and unassigned ghost Oct 24, 2017
@Avasam
Copy link
Collaborator

Avasam commented Mar 24, 2024 •
edited

These improvements would be caught automatically by Ruff's collection-literal-concatenation (RUF005)

This was referenced Mar 24, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated com enhancement sourceforge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer unpacking over concatenating Avasam/pywin32
1 participant
@Avasam