Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PRINTER_INFO_6 support in Set/GetPrinter #1853

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Add PRINTER_INFO_6 support in Set/GetPrinter #1853

merged 5 commits into from
Apr 14, 2022
+57 −50

Conversation

CristiFati
Copy link
Contributor

According to [MS.Docs]: GetPrinter function, PRINTER_INFO_6 (and thus level 6), is a valid choice.

Note: there's not much extra real value, as the status is also included in PRINTER_INFO_2.

mhammond
mhammond requested changes Apr 11, 2022
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great to add a short note to CHANGES.txt giving yourself credit!

@CristiFati CristiFati requested a review from mhammond April 13, 2022 03:52
mhammond
mhammond approved these changes Apr 14, 2022
View reviewed changes
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! 👍

@mhammond mhammond merged commit 5052346 into mhammond:main Apr 14, 2022
@CristiFati CristiFati deleted the cfati_dev00 branch May 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CristiFati @mhammond