GSS-API wrap and unwrap operation for the sspi module #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the last check was stuck and has failed... |
Me either, but it's a regular occurrence :( At a quick glance this PR looks great - I'll try and find time to look in more detail soon. In the meantime, could you please add an entry to CHANGES.txt, giving yourself whatever credit you like :) |
|
Hello @mhammond, do you think you will accept this PR after a second thought ? if yes, have you any idea of when it will be the case ? |
|
Sorry for the delay - I'll certainly have a good look before the next release, but I can't predict when that might be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sspi module offers nice classes to deal with SSPI authentication process.
But these classes miss the wrap and unwrap methods that are present in the GSS-API. Microsoft described how to emulate such calls. This pull request introduces an implementation of the described method. This code has been tested against a real MIT Kerberos on Linux.
The PR also enhances the example at the end of the file, enabling it to work with either Kerberos or NTLM.