Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast path to UnicodeBreakProperties::find_words #333

Open
mgeisler opened this issue May 2, 2021 · 0 comments
Open

Add fast path to UnicodeBreakProperties::find_words #333

mgeisler opened this issue May 2, 2021 · 0 comments
Labels
enhancement help wanted
Projects
Traits for finding and wrapping words

Comments

@mgeisler
Copy link
Owner

mgeisler commented May 2, 2021

The method is terribly complex and somewhat slow — we should rework it to have a fast path for the case where we don't see any CSI characters in the string.

Originally posted by @mgeisler in #313 (comment)
@mgeisler mgeisler mentioned this issue May 2, 2021
Merged
@mgeisler mgeisler changed the title Add fast past to UnicodeBreakProperties::find_words Add fast path to UnicodeBreakProperties::find_words May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
No open projects
Traits for finding and wrapping words
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgeisler