Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with new "TOTAL" line in coverage >= 5.4 #20

Closed
dvzrv opened this issue Feb 4, 2021 · 4 comments
Closed

Problems with new "TOTAL" line in coverage >= 5.4 #20

dvzrv opened this issue Feb 4, 2021 · 4 comments

Comments

@dvzrv
Copy link

dvzrv commented Feb 4, 2021

Hi! The plugin unfortunately breaks on coveragepy >= 5.4, as they have introduced an additional TOTAL line also for single file reports: nedbat/coveragepy#1086

When trying to display coverage this looks roughly as the following:

Running coverage report -m <directory>/<file>.py
Got confused by 'TOTAL                         1228    113    510     20    89.36%'
Expected it to start with '<directory>/<file> '
Full output:
Name                         Stmts   Miss Branch BrPart     Cover   Missing
---------------------------------------------------------------------------
<directory>/<file>.py    1228    113    510     20    89.36%   43->47, 47-50, 78->82, 82-85, 113->117, 117-120, 212, 352-418, 616->617, 616->620, 617-623, 656->657, 656->661, 657-661, 691->692, 691->696, 692-696, 989->990, 990, 1029->1033, 1033, 1067->1071, 1071, 1105->1109, 1109, 3455->3456, 3455->3459, 3456-346
2, 3516->3521, 3521, 3551-3555, 3584->3585, 3585, 3615->3616, 3616, 4343-4366, 4396-4419, 4590->4591, 4590->4594, 4591-4603, 4991-5010
---------------------------------------------------------------------------
TOTAL                         1228    113    510     20    89.36%
@mgedmin
Copy link
Owner

mgedmin commented Feb 4, 2021

I've merged a pull request fixing this very recently (#19). Can you double-check if you're using the latest plugin code?

@dvzrv
Copy link
Author

dvzrv commented Feb 4, 2021

@mgedmin Thanks for the fast response!
I'm currently packaging 3.0.1 on Arch Linux but can certainly apply the patch from that pull request (sorry, I didn't look before writing), but it does not apply cleanly.

It would be awesome if you can find the time to tag another release, which includes this fix.

@mgedmin
Copy link
Owner

mgedmin commented Feb 4, 2021

Oops, I've forgotten to add git tags after bumping the version!

Tagged 3.3 now (and also the forgotten earlier 3.2 and 3.1).

@mgedmin mgedmin closed this as completed Feb 4, 2021
@dvzrv
Copy link
Author

dvzrv commented Feb 4, 2021

Many thanks! Updating now! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants