Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle new PyPy versions notations for GHA correctly #24

Closed
icemac opened this issue Dec 18, 2020 · 4 comments · Fixed by #25
Closed

Does not handle new PyPy versions notations for GHA correctly #24

icemac opened this issue Dec 18, 2020 · 4 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@icemac
Copy link

icemac commented Dec 18, 2020

This came up in: zopefoundation/zope.publisher#58 (comment)

There are new variants to request a specific PyPy version on GHA which are currently not recognized by the checker as valid PyPy versions.

@mgedmin
Copy link
Owner

mgedmin commented Dec 18, 2020

It would be helpful if I could see what the YAML looks like.

@mgedmin
Copy link
Owner

mgedmin commented Dec 18, 2020

Ok, as far as I understand, there was a new release of actions/setup-python, version 2.2.0, which moved the v2 tag (yay! aren't git tags supposed to be unchanging?). This release extended the Python version syntax to allow pypy-X.Y and pypy-X.Y-vA.B.C, and it also included a regression where the old pypy2/pypy3 versions stopped working.

Later there was a v2.2.1 release (which moved the v2 tag again), and now all syntaxes work fine.

check-python-versions supports only the old pypyX syntax and needs to be extended to support pypy-X.Y[-vA.B.C].

@mgedmin mgedmin added the enhancement New feature or request label Dec 18, 2020
mgedmin added a commit that referenced this issue Dec 18, 2020
@mgedmin
Copy link
Owner

mgedmin commented Dec 18, 2020

Ok, this should be fixed now.

Apologies for the inconvenience!

@icemac
Copy link
Author

icemac commented Jan 21, 2021

Thank you for looking into this issue. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants