Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

People expect check-manifest to check MANIFEST.in syntactically #85

Open
mgedmin opened this issue Oct 23, 2018 · 3 comments
Open

People expect check-manifest to check MANIFEST.in syntactically #85

mgedmin opened this issue Oct 23, 2018 · 3 comments
Labels
enhancement help-needed

Comments

@mgedmin
Copy link
Owner

mgedmin commented Oct 23, 2018

It would be good if check-manifest didn't ignore directives it didn't recognize but instead complained about them. Because people expect check-manifest to check MANIFEST.in for syntactic validity.

See zopefoundation/BTrees#99 (comment) for an example.
@mgedmin mgedmin mentioned this issue Oct 23, 2018
Merged
@mgedmin
Copy link
Owner Author

mgedmin commented Oct 23, 2018

Hey, since I'm already running python setup.py sdist in a subprocess, all I'd have to do is capture the stderr and show it. Probably.

@jayvdb
Copy link

jayvdb commented May 8, 2019

#33 is another example of people expecting check-manifest to check the manifest.

@mgedmin
Copy link
Owner Author

mgedmin commented May 8, 2019

jayvdb commented 5 hours from now

Hey, can I borrow your time machine? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @mgedmin