Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-manifest isn't aware of links #69

Open
tomschr opened this issue Jun 5, 2016 · 1 comment
Open

check-manifest isn't aware of links #69

tomschr opened this issue Jun 5, 2016 · 1 comment

Comments

@tomschr
Copy link

tomschr commented Jun 5, 2016

Thanks for this package! Very cool! :)

Assume I have a tests directory which contains a cases and a struct subdirectory. The latter contains a link. This looks like this:

tests/
├── cases
│   ├── data
│   │   ├── topic1.xml
│   │   ├── topic2.xml
│   │   └── topic3.xml
│  [... some more files, pruned ...]
├── struct
│   ├── data -> ../cases/data
└── [...]

As I want to include the complete tests directory, my MANIFEST.in contains the following line:

recursive-include tests *

When I run check-manifest I get the following errors:

$ check-manifest .

lists of files in version control and sdist do not match!
missing from VCS:
  tests/struct/data/topic1.xml
  tests/struct/data/topic2.xml
  tests/struct/data/topic3.xml
missing from sdist:
  tests/struct/data

However, this is wrong. The directory tests/struct/data is actually a link pointing to tests/cases/data and these files are already tracked by Git.

I suspect that check-manifest doesn't recognize links as such. Is my assumption true?
(For more information see my repository https://github.com/tomschr/dbassembly)

@tomschr tomschr changed the title check-manifest doesn't follow links check-manifest isn't aware of links Jun 5, 2016
tomschr added a commit to tomschr/dbassembly that referenced this issue Jun 5, 2016
Links were not recognized by check-manifest. See mgedmin/check-manifest#69
@mgedmin
Copy link
Owner

mgedmin commented Jun 6, 2016

You're right: check-manifest currently ignores file types and just compares recursive directory listings (produced by reading the output of external commands such as tar xvzf and git ls).

I'm not sure how to fix this!

zogzog pushed a commit to zogzog/cubicweb that referenced this issue Feb 18, 2020
These are not handled by check-manifest, see mgedmin/check-manifest#69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants