Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-manifest should parse and consider .gitignore file #129

Open
jhermann opened this issue Nov 3, 2020 · 1 comment
Open

check-manifest should parse and consider .gitignore file #129

jhermann opened this issue Nov 3, 2020 · 1 comment
Labels
enhancement help-needed

Comments

@jhermann
Copy link

jhermann commented Nov 3, 2020 •
edited

"missing from VCS" lists files I already excluded via .gitignore; needing to list them a 2nd time in the tool config is waste and more brittle that it'd need to be.

https://github.com/mherrmann/gitignore_parser is a maintained implementation.

check-manifest version 0.45

cf. #60
@mgedmin
Copy link
Owner

mgedmin commented Nov 3, 2020

This is a very good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help-needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgedmin @jhermann