Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on distutils #121

Open
mgedmin opened this issue Sep 8, 2020 · 0 comments
Open

Do not depend on distutils #121

mgedmin opened this issue Sep 8, 2020 · 0 comments

Comments

@mgedmin
Copy link
Owner

mgedmin commented Sep 8, 2020

In 21d3969 I added a dependency on distutils.text_file.TextFile() because I thought that's what setuptools used to read MANIFEST.in files.

Later I realized that was wrong and that setuptools has its own code for this. I decided to stay with distutils because the stdlib moves slower, and I thought this would protect check-manifest users from breaking changes in setuptools.

However this comes at the cost of accuracy, and also people are talking about deprecating distutils: https://discuss.python.org/t/pep-632-deprecate-distutils-module/5134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant