adds checks for protobuf struct tags #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@git-hulk reviews are welcome |
git-hulk
reviewed
Jul 14, 2022
rule/struct-tag.go
Outdated
| for _, opt := range tag.Options { | ||
| if _, err := strconv.Atoi(opt); err == nil { | ||
| _, alreadySeen := w.usedTagNbr[opt] | ||
| fmt.Printf("opt %s already seen? %v\n", opt, alreadySeen) |
There was a problem hiding this comment.
We should remove this print line?
git-hulk
reviewed
Jul 14, 2022
rule/struct-tag.go
Outdated
| if alreadySeen { | ||
| return fmt.Sprintf("duplicated tag number %s", opt), false | ||
| } | ||
| w.usedTagNbr[opt] = true |
There was a problem hiding this comment.
014 and 14 will NOT regard as duplicate tag number since we use raw string as key, but I think no one will do that.
There was a problem hiding this comment.
I've modified the code to use ints as key
removes debug println
git-hulk
approved these changes
Jul 14, 2022
mgechev
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of protobuf struct tags to the rule
struct-tag