Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration to be passed in to library mode #654

Closed
heynemann opened this issue Mar 21, 2022 · 3 comments
Closed

Allow configuration to be passed in to library mode #654

heynemann opened this issue Mar 21, 2022 · 3 comments

Comments

@heynemann
Copy link
Contributor

I was checking how golangci-lint uses revive and they seem to have copied a substantial part of the codebase.

Now that it is possible to run revive as a library I was thinking of making a PR to golangci-lint to improve revive's usage there. The only thing missing is passing in configuration and being able to call revive without the CLI arguments (why they copied I believe).

Do you think it is a good step forward? Decoupling the CLI part with the linting part of revive? I can get a draft PR...
@chavacava
Copy link
Collaborator

After merging your last PR I immediatly thinked on golang-ci and how we could facilitate the integration of revive.

@heynemann
Copy link
Contributor Author

Will get a draft PR as soon as possible for us to work on this...

@heynemann heynemann mentioned this issue Mar 22, 2022
Merged
@chavacava
Copy link
Collaborator

Closed by #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heynemann @chavacava