Update error-strings rule (#608) #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavacava
reviewed
Oct 27, 2021
doniacld
force-pushed
the
fix-608-error-strings-update
branch
from
cf3e056
to
2b7c1d7
Compare
|
Thanks @doniacld ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #608.
Adds new packages from https://pkg.go.dev/github.com/pkg/errors to error-strings rule.
I see one problem in the current implementation, this is the aliasing of imports.
I assumed projects wether use the standard library
errorsorgithub.com/pkg/errorsbut not both at the same time.Anyway it could be a nice to have.
Test
I added one fixture file containing the new methods from github.com/pkg/errors.