Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule.error-strings does not catch errors.Wrap messages #608

Closed
mrd0ll4r opened this issue Oct 27, 2021 · 2 comments · Fixed by #609
Closed

rule.error-strings does not catch errors.Wrap messages #608

mrd0ll4r opened this issue Oct 27, 2021 · 2 comments · Fixed by #609

Comments

@mrd0ll4r
Copy link

Using rule.error-strings, I expected a warning from code like this:

err := somethingFallible()
if err != nil {
  return errors.Wrap(err, "Something terrible happened.")
}

I'm not sure if the usual error string formatting applies here, but I would expect that it does...

  • OS: Latest Ubuntu (e.g. whatever is used in GitHub runners)
  • Version of Go: 1.16
@chavacava
Copy link
Collaborator

Hi @mrd0ll4r thanks for filling the issue.

@doniacld
Copy link
Contributor

Hey !
I would be happy to work on this issue! :)

doniacld added a commit to doniacld/revive that referenced this issue Oct 27, 2021
doniacld added a commit to doniacld/revive that referenced this issue Oct 27, 2021
doniacld added a commit to doniacld/revive that referenced this issue Oct 28, 2021
chavacava added a commit that referenced this issue Oct 28, 2021
Co-authored-by: SalvadorC <salvadorcavadini+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants