Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser & a gh workflow #503

Merged
merged 2 commits into from Mar 18, 2021
Merged

Add goreleaser & a gh workflow #503

merged 2 commits into from Mar 18, 2021

Conversation

Clivern
Copy link
Contributor

@Clivern Clivern commented Mar 16, 2021

Why
It should be handy to get revive binary without installing go. also I want to add revive inside dockerfile without a dedicated stage to build the binary. So I will have a place to get binaries from (related to #489):

curl -sL https://github.com/mgechev/revive/releases/download/vx.x.x/revive_x.x.x_OS.tar.gz | tar xz

How
With this PR, every time you create a tag, release github workflow runs to build binaries (linux, windows, mac) and upload them to releases section on github https://github.com/mgechev/revive/releases. It also add the changelog from commits.

@mgechev mgechev merged commit f8f4bf2 into mgechev:master Mar 18, 2021
@mgechev
Copy link
Owner

mgechev commented Feb 8, 2022

@Clivern looks like the recent actions have been failing. Interesting why without changes the secret seems to no longer work? https://github.com/mgechev/revive/runs/5102785873?check_suite_focus=true

@Clivern
Copy link
Contributor Author

Clivern commented Feb 8, 2022

@mgechev I think this is related to this PR #590. It doesn't authenticate with gitHub docker registry to push the docker image. I think it can be fixed by adding this step in https://github.com/mgechev/revive/blob/master/.github/workflows/release.yml

      - name: Log into registry
        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login docker.pkg.github.com -u ${{ github.actor }} --password-stdin

Opened a PR for that #630

cc @doniacld

@mgechev
Copy link
Owner

mgechev commented Feb 9, 2022

Thanks for looking into this!

@mgechev
Copy link
Owner

mgechev commented Feb 9, 2022

Getting a similar failure here. For some reason docker doesn't consume the token via stdin properly?

@Clivern
Copy link
Contributor Author

Clivern commented Feb 9, 2022

nope, goreleaser push to ghcr.io while i used docker.pkg.github.com. better to use ghcr, final fix #631

@mgechev
Copy link
Owner

mgechev commented Feb 10, 2022

The release is green now. Thank you for the fixes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants