Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore blank import of embed if embed is actually used in the file #501

Merged
merged 2 commits into from Mar 6, 2021
Merged

Ignore blank import of embed if embed is actually used in the file #501

merged 2 commits into from Mar 6, 2021

Conversation

grongor
Copy link
Contributor

@grongor grongor commented Feb 26, 2021

Closes #500

chavacava
chavacava requested changes Feb 27, 2021
View reviewed changes
Copy link
Collaborator

@chavacava chavacava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grongor, thanks for the PR. I've made a couple of remarks.

rule/blank-imports.go Outdated Show resolved Hide resolved
rule/blank-imports.go Outdated Show resolved Hide resolved
@chavacava chavacava merged commit 535f426 into mgechev:master Mar 6, 2021
@chavacava
Copy link
Collaborator

@grongor thanks for the PR and sorry for the late response (it was a busy week)

@grongor
Copy link
Contributor Author

grongor commented Mar 6, 2021

No worries, thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chavacava chavacava chavacava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't consider blank import of "embed" (Go 1.16) an error
2 participants
@grongor @chavacava