Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with null attribute #6

Open
weierophinney opened this issue Dec 31, 2019 · 1 comment
Open

Link with null attribute #6

weierophinney opened this issue Dec 31, 2019 · 1 comment

Comments

@weierophinney
Copy link
Contributor

Creating a Link with a null attribute, I get an InvalidArgumentException. I'm not 100% sure about it but I guess that having null attributes should be allowed in Hal links

Code to reproduce the issue

new Link('a', 'b', false, ['c' => null]);

Expected results

I would expect to get a Link with a c attribute with a null value

Actual results

An InvalidArgumentException with message Zend\\Expressive\\Hal\\Link expects the $value to be a PHP primitive or array of strings; received NULL is thrown


Originally posted by @marcosh at zendframework/zend-expressive-hal#46

alexmerlin added a commit to alexmerlin/mezzio-hal that referenced this issue Apr 19, 2023
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
alexmerlin added a commit to alexmerlin/mezzio-hal that referenced this issue Apr 19, 2023
* Issue mezzio#6: Allow Link creation with null attribute.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>

---------

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
alexmerlin added a commit to alexmerlin/mezzio-hal that referenced this issue Apr 19, 2023
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
alexmerlin added a commit to alexmerlin/mezzio-hal that referenced this issue Apr 20, 2023
* Issue mezzio#6: Allow Link creation with null attribute.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>

---------

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
alexmerlin added a commit to alexmerlin/mezzio-hal that referenced this issue Apr 20, 2023
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@Xerkus
Copy link
Member

Xerkus commented Apr 20, 2023

Latest draft for HAL defines Link object with attributes that are optional but not empty.
https://datatracker.ietf.org/doc/html/draft-kelly-json-hal-08#section-5

I do not think attributes with null values should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants