Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public test suite for compatibility check #50

Open
aqrln opened this issue Feb 6, 2017 · 2 comments
Open

Public test suite for compatibility check #50

aqrln opened this issue Feb 6, 2017 · 2 comments
Labels

Comments

@aqrln
Copy link
Member

aqrln commented Feb 6, 2017

In order to ensure that our JSTPMobile/iOS, JSTPMobile/Java, DzyubSpirit/JSTPHaskell and possibly any other third-party implementations do the serialization and parsing and form packets correctly, we need a public test suite for conformance check.

@nechaido
Copy link
Member

@aqrln we could probably close this because we now have test/fixtures

@lundibundi
Copy link
Member

@nechaido I think it's not appropriate to call them as such, even though third-party implementation should comply with some of them. Because they still are format specific to the js implementation, I think we should come up with some sort of format for the cases or at least remove js specific parts (such as export), also not all of those tests should be checked against and in my opinion it's better to put them in at least separate directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants