Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML spans within MathML should not be namespaced as MathML under Nokogiri 1.11 #64

Closed
opoudjis opened this issue May 19, 2021 · 2 comments
Closed

HTML spans within MathML should not be namespaced as MathML under Nokogiri 1.11 #64

opoudjis opened this issue May 19, 2021 · 2 comments
Assignees
@opoudjis

Comments

@opoudjis
Copy link
Contributor

Arises from #63
@opoudjis opoudjis self-assigned this May 19, 2021
@opoudjis opoudjis mentioned this issue May 19, 2021
Merged
@opoudjis opoudjis changed the title HTML spans within MathML should not be namespaced as MathML HTML spans within MathML should not be namespaced as MathML under Nokogiri 1.11 May 19, 2021
@opoudjis
Copy link
Contributor Author

This results from rubys/nokogumbo#160 . It's an update that does make sense (if you add a child node, inherit its namespace), but we do need to now explicitly namespace the inserted spans as HTML.

@opoudjis
Copy link
Contributor Author

In fact, we are having to do this manually, by stripping the namespaces in text: Word MHT cannot parse the explicit HTML namespaces, which Nokogiri 1.11 is inserting here.

opoudjis added a commit that referenced this issue May 19, 2021
@opoudjis
force strip namespace of span/em within MathML: #64
88e429a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opoudjis opoudjis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@opoudjis