Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerge PR workflow v2 #94

Open
2 of 3 tasks
CAMOBAP opened this issue Sep 6, 2022 · 3 comments
Open
2 of 3 tasks

Automerge PR workflow v2 #94

CAMOBAP opened this issue Sep 6, 2022 · 3 comments
Assignees

Comments

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Sep 6, 2022

Background

We already had this task in the past #45 after resolving issues it worked at some point.

But for the last update, it stop working for instance this PR metanorma/metanorma-model-standoc#39

Action items

  • investigate why it breaks
  • review again approaches to implement automerge
  • implement approach

Conditions:

  • all checks are passed
  • PR is not in draft state
@CAMOBAP CAMOBAP self-assigned this Sep 6, 2022
@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Apr 17, 2023

Per https://github.com/pascalgn/automerge-action

The action will only wait for status checks that are marked as required in the branch protection rules

So probably our checks aren't required can be checked with API call https://docs.github.com/en/rest/checks/suites?apiVersion=2022-11-28#list-check-suites-for-a-git-reference

Also we can request them explicitly in the commit message request-checks: true as described here https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Sep 6, 2023

commit message request-checks: true doesn't work

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Nov 29, 2023

pascalgn/automerge-action#234 - looks like exact description of the problem, to be implemented as in second comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant