Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix sockets #1105

Closed
aviramha opened this issue Feb 22, 2023 · 4 comments
Closed

Support unix sockets #1105

aviramha opened this issue Feb 22, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@aviramha
Copy link
Member

aviramha commented Feb 22, 2023

Support making outgoing connections from to unix sockets on the remote pod.

Requested by customer who's application reads from the containerd socket.

@aviramha
Copy link
Member Author

blocked by rust-lang/socket2#332

@t4lz t4lz self-assigned this Feb 24, 2023
@aviramha
Copy link
Member Author

Adding more information, as I initially started implementing it and have some thoughts:

  1. This should be part of the "outgoing" configuration, a field named unix (feel free to suggest other) that accepts path patterns to connect remotely.
  2. This should leverage the TCP outgoing handler, as it is pretty similar to it in terms of everything (connect, send/recv).
  3. Above point is debatable, but I don't really think that splitting and complicating the code makes sense.

@t4lz
Copy link
Member

t4lz commented Feb 28, 2023

2. This should leverage the TCP outgoing handler

Does this mean that for now we are only going to support TCP over unix sockets, not UDP?

@aviramha
Copy link
Member Author

aviramha commented Feb 28, 2023

It's possible to have UDP over unix sockets? For some reason I didn't think it's possible.
I suggest we start with TCP over unix then have another issue for UDP (to be prioritized when needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants