Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect warning shown #176

Open
eyalb181 opened this issue Oct 7, 2023 · 1 comment
Open

Incorrect warning shown #176

eyalb181 opened this issue Oct 7, 2023 · 1 comment
Assignees
@meowjesty
Labels
bug Something isn't working

Comments

@eyalb181
Copy link
Member

eyalb181 commented Oct 7, 2023

Bug Description

The following warning is shown when using steal mode and not specifying a target:
"Steal mode is not compatible with a targetless agent, please either disable this option or specify a target."

It shouldn't be shown since the user can still select a target in the dropdown.

Steps to Reproduce

Use steal mode in the IDE.

Backtrace

No response

Relevant Logs

No response

Your operating system and version

N/A

Local process

N/A

Local process version

No response

Additional Info

No response
@eyalb181 eyalb181 added the bug Something isn't working label Oct 7, 2023
@meowjesty
Copy link
Member

Wait, how is this even possible? We don't have this warning anymore:

https://github.com/metalbear-co/mirrord/blob/a5488d593c7f2c7573aba155c196c564746f925d/mirrord/config/src/lib.rs#L392C9-L420

@eyalb181 eyalb181 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
@eyalb181 eyalb181 reopened this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meowjesty meowjesty

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyalb181 @meowjesty