Unify/fix log messages

[lentzi90]

• Make sure NIC is written in all capital letters:

  cluster-api-provider-metal3/baremetal/metal3data_manager.go

  Lines 1389 to 1396 in bec1704

  	return "", errors.New("Nics list not populated")
  	}
  	for _, nics := range bmh.Status.HardwareDetails.NIC {
  	if nics.Name == name {
  	return nics.MAC, nil
  	}
  	}
  	return "", fmt.Errorf("nic name not found %v", name)

• Write out "Metal3DataClaim" instead of Claim:

  cluster-api-provider-metal3/baremetal/metal3data_manager.go

  Line 1416 in bec1704

  return nil, errors.New("Claim name not set")

• Write MAC in all capital letters:

  cluster-api-provider-metal3/baremetal/metal3data_manager.go

  Line 1274 in bec1704

  return "", fmt.Errorf("bad mac address: %s", macaddress)

• Delete misleading log:

  cluster-api-provider-metal3/baremetal/metal3data_manager.go

  Line 905 in bec1704

  m.Log.Info("allocating", "addr", a)

• Write out Metal3IPClaim for consistency:

  cluster-api-provider-metal3/baremetal/metal3data_manager.go

  Line 627 in bec1704

  m.Log.Info("Ensuring M3IPClaim for Metal3Data", "Metal3Data", m.Data.Name)

[lentzi90]

/good-first-issue
/triage accepted

[metal3-io-bot]

@lentzi90:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MeenuyD]

/assign