Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition in Browse models filter #42574

Draft
wants to merge 1 commit into
base: improve-user-settings-hook
Choose a base branch
from
Draft

Avoid race condition in Browse models filter #42574

wants to merge 1 commit into from
+6 −1

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 13, 2024 •
edited

@rafpaf rafpaf added this to the 0.50 milestone May 13, 2024
@rafpaf rafpaf self-assigned this May 13, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 13, 2024
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label May 13, 2024
@rafpaf rafpaf marked this pull request as ready for review May 13, 2024 14:13
@graphite-app graphite-app bot requested a review from a team May 13, 2024 14:13
@graphite-app Graphite App
Copy link

graphite-app bot commented May 13, 2024 •
edited

Graphite Automations

"Don't backport" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

"Notify author when CI fails" took an action on this PR • (05/17/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

@iethree iethree removed this from the 0.50 milestone May 13, 2024
@replay-io replay.io
Copy link

replay-io bot commented May 13, 2024 •
edited

Status Complete ↗︎
Commit 41391fb
Results
❌ 1 Failed
⚠️ 4 Flaky
✅ 2522 Passed

@rafpaf rafpaf marked this pull request as draft May 13, 2024 20:20
@rafpaf rafpaf changed the base branch from master to improve-user-settings-hook May 13, 2024 20:25
@rafpaf Graphite App
Copy link
Contributor Author

rafpaf commented May 13, 2024 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@rafpaf rafpaf mentioned this pull request May 13, 2024
Open
@rafpaf rafpaf force-pushed the improve-user-settings-hook branch from a672a24 to 6628f19 Compare May 17, 2024 10:17
@rafpaf rafpaf marked this pull request as ready for review May 17, 2024 10:19
@rafpaf rafpaf added this to the 0.50 milestone May 17, 2024
@rafpaf rafpaf marked this pull request as draft May 17, 2024 14:56
@rafpaf rafpaf removed this from the 0.50 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafpaf rafpaf

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition in Browse models filter
2 participants
@rafpaf @iethree