Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin maps may remain visible on dashboards even when 'Hide this card if there are no results' is set and there is no data to display #42569

Open
zbodi74 opened this issue May 13, 2024 · 0 comments
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Maps

Comments

@zbodi74
Copy link

zbodi74 commented May 13, 2024

Describe the bug

Pin maps do not display records if the coordinates are incomplete. However, a card on a dashboard can only be hidden if the underlying question returns an empty result set.

This opens an edge case - when results exist but the coordinates are incomplete, and the card remains visible.
We should consider displaying a warning in this case to clarify why the card does not disappear, as users might expect it to if there are perceived to be no results.

To Reproduce

  1. Create a data set with coordinates where each record has an incomplete coordinate (one of the values or both are null)
  2. Display it on a pin map, save it, and add it to a dashboard
  3. Set 'Hide this card if there are no results' for this card on the dashboard
    4.(!) The card remains to be visible, in a blank state, showing 'No results!'.

Expected behavior

The current behavior is confusing.
We should consider displaying a message on a blank card that reads, 'No displayable records. N records are hidden due to incomplete coordinates.' This would clarify why results are not being shown, despite their presence.

A possible workaround is to filter out records with empty coordinates from the dataset. However, it might be more beneficial to display a warning to keep the user informed about the presence of such records, which could be valuable information that would otherwise remain unknown.

Logs

No response

Information about your Metabase installation

1.49.8

Severity

P3

Additional context

No response

@zbodi74 zbodi74 added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Needs Triage Visualization/Maps labels May 13, 2024
@alxnddr alxnddr added .Team/DashViz Dashboard and Viz team and removed .Needs Triage labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Maps
Projects
None yet
Development

No branches or pull requests

2 participants