Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate jspdf and html2canvas from the vendors chunk #42551

Closed
Tracked by #42550
uladzimirdev opened this issue May 13, 2024 · 0 comments · Fixed by #42536
Closed
Tracked by #42550

separate jspdf and html2canvas from the vendors chunk #42551

uladzimirdev opened this issue May 13, 2024 · 0 comments · Fixed by #42536
Assignees
@uladzimirdev

Comments

@uladzimirdev
Copy link
Contributor

uladzimirdev commented May 13, 2024 •
edited

Even if html2canvas and jspdf dependencies are marked to be loaded lazily, webpack doesn't automatically create separate chunks for them in current configuration

e.g.

metabase/frontend/src/metabase/visualizations/lib/save-chart-image.ts

Line 24 in 6cc0f2b

const { default: html2canvas } = await import("html2canvas");

image image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uladzimirdev uladzimirdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude jspdf and html2canvas from the bundle metabase/metabase
1 participant
@uladzimirdev