Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nock unit test flakes #28489

Closed
2 tasks
iethree opened this issue Feb 21, 2023 · 0 comments
Closed
2 tasks

Fix nock unit test flakes #28489

iethree opened this issue Feb 21, 2023 · 0 comments
Assignees
@ranquild
Labels
.CI & Tests

Comments

@iethree
Copy link
Contributor

iethree commented Feb 21, 2023 •
edited by ranquild

Apparently there are some real issues with Jest + Nock. Even if you try to import nock in setupFilesAfterEnv running our test suite fails with an EOM error. We might need to reconsider our library choice for request mocking 馃槥

Jest --detectLeaks reports memory leaks on nock.cleanAll() and nock.restore() nock/nock#2358
Jest leaking memory even after calling nock.restore() nock/nock#2383

Tasks
Beta Give feedback
@iethree iethree mentioned this issue Feb 21, 2023
Closed
@iethree iethree assigned iethree and ranquild and unassigned iethree Feb 21, 2023
@iethree iethree changed the title Add a draft title or issue reference here Fix nock unit test flakes Feb 21, 2023
@ranquild ranquild mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.CI & Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ranquild @iethree