New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move from objects to Maps #5468
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5468 +/- ##
==========================================
- Coverage 5.73% 5.72% -0.01%
==========================================
Files 277 278 +1
Lines 41999 42018 +19
Branches 515 490 -25
==========================================
Hits 2407 2407
- Misses 39592 39611 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yash-Singh1 were you able to fix the tests? |
Hi @sidharthv96, sorry for the late reply, I was busy with exams. I just fixed the e2e tests. |
No worries @Yash-Singh1! Hope they went well :) |
📑 Summary
Switches from objects to
Map
s in places where the keys accepted are user inputs.Resolves #5451
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
This is a breaking change for v11 since it changes the structure of the databases and as such can break code that relies on the db, e.g.
https://github.com/excalidraw/mermaid-to-excalidraw/blob/d0b00dc63eeabd5e92ca3997650f47bf4901cb2c/src/parser/flowchart.ts#L226
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch