Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and accDescription to chart examples #2904

Closed
lindseywild opened this issue Apr 6, 2022 · 0 comments · Fixed by #3523
Closed

Add title and accDescription to chart examples #2904

lindseywild opened this issue Apr 6, 2022 · 0 comments · Fixed by #3523
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request

Comments

@lindseywild
Copy link
Contributor

lindseywild commented Apr 6, 2022

Is your feature request related to a problem? Please describe.
In order to help make the charts more accessible, it'd be great if we could include the newly added title and description to the examples (i.e. https://github.com/mermaid-js/mermaid/blob/develop/docs/pie.md)

Describe the solution you'd like
In the examples, ensure that title and accDescription exist in the example code.

Additional context
This is dependent on #2732 and which chart types have implemented the new fields. I think it should wait until that issue is complete before doing this.

@lindseywild lindseywild added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request labels Apr 6, 2022
@lindseywild lindseywild changed the title Add title and accDescription to chart templates in the live editor Add title and accDescription to chart examples Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant