Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint-scss #16

Closed
jantimon opened this issue Jul 16, 2019 · 5 comments
Closed

Add stylelint-scss #16

jantimon opened this issue Jul 16, 2019 · 5 comments
Assignees

Comments

@jantimon
Copy link
Contributor

Have you considered to add the stylelint plugin stylelint-scss?

It allows to disallow scss code like the following:

.class {
  &-union {
//↑
// This type usage of `&`
  }
}

https://github.com/kristerkari/stylelint-scss/blob/master/src/rules/selector-no-union-class-name/README.md

@ernscht
Copy link
Member

ernscht commented Jul 16, 2019

I also liked the idea very much. I tried it recently.
But I only had problems (especially in combination with our current rules and plugin usage). And I was afraid to check if it is fixable.

@jantimon
Copy link
Contributor Author

jantimon commented Jul 18, 2019

You are right - I also had this issue:

stylelint-scss/stylelint-scss#345

We will probably need some investigation to ensure that it will not break our linting before we merge it into the defaults.

The maintainer is really fast - so hopefully we can sort out those bugs without much work.

@smollweide
Copy link
Contributor

stylelint-scss/stylelint-scss#345

is solved. Can we add stylelint-scss?

@ernscht ernscht self-assigned this Oct 29, 2019
@ernscht
Copy link
Member

ernscht commented Oct 29, 2019

I'll make a suggestion

smollweide added a commit that referenced this issue Nov 5, 2019
feat(stylelint): add stylelint-scss and some scss rules #16
@ernscht
Copy link
Member

ernscht commented Nov 5, 2019

released in 0.4.0

@ernscht ernscht closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants