Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port code from recovery lexer to master branch #40

Closed
KFlash opened this issue Aug 26, 2019 · 1 comment
Closed

Port code from recovery lexer to master branch #40

KFlash opened this issue Aug 26, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@KFlash
Copy link
Contributor

KFlash commented Aug 26, 2019 •
edited

RL are taking up all my time now, so just dumped my "recovery lexer" code on the recovery branch. Some part of the lexer code is either new or a improvement over what exist on the Master branch now and can be ported before bumping version to v. 1.7.

I didn't care about fixing lint errors, but all tests pass. And it recover from all lexer errors as seen in this tests

See #39 for future plans for 2.0

cc / @aladdin-add Time to look into this? It's mostly copy & paste
@KFlash KFlash added the help wanted Extra attention is needed label Aug 26, 2019
@KFlash
Copy link
Contributor Author

KFlash commented Sep 1, 2019

Closing as I already copy & paste from the new lexer code where it's possible. The other changes will land in v. 2.0.

@KFlash KFlash closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KFlash