fix(parser): super call should be allowed in private method #210
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the error message for invalid super call. closes #203
|
I am really uncomfortable with the removal of the two lines There is probably some missing test case for the ClassField branch (with some kind of super call? to test the InClass logic in parseSuperExpression). |
aladdin-add
reviewed
Mar 18, 2022
aladdin-add
approved these changes
Mar 18, 2022
|
Any idea why the ClassField sets InClass before? I removed it because I cannot think of a test case requiring that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the error message for invalid super call.
closes #203