Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect .loc.start.column for node inside return statement #207

Closed
bartosz-k opened this issue Mar 8, 2022 · 3 comments · Fixed by #208
Closed

Incorrect .loc.start.column for node inside return statement #207

bartosz-k opened this issue Mar 8, 2022 · 3 comments · Fixed by #208
Assignees
@3cp

Comments

@bartosz-k
Copy link

bartosz-k commented Mar 8, 2022 •
edited

In example function f(){return a(b)}; an incorrect .loc.start.column for CallExpression is generated. column for whole CallExpression is higher than column for callee subnode.
@bartosz-k bartosz-k changed the title Incorrect.loc.start inside return statement Incorrect .loc.start for node inside return statement Mar 8, 2022
@bartosz-k bartosz-k changed the title Incorrect .loc.start for node inside return statement Incorrect .loc.start.column for node inside return statement Mar 8, 2022
@3cp 3cp self-assigned this Mar 9, 2022
3cp added a commit that referenced this issue Mar 13, 2022
@3cp
fix(parser): fix wrong starting loc for any non-trival expression in …
7063af5 
…return statement

closes #207
@3cp 3cp mentioned this issue Mar 13, 2022
Merged
@3cp
Copy link
Member

3cp commented Mar 13, 2022

That code mistake was not covered by our unit tests :-(
There are other bugs I want to work on before releasing a new version. Might take 2 or 3 weeks.
Cheers!

@3cp 3cp closed this as completed in #208 Mar 14, 2022
@bartosz-k
Copy link
Author

Great, thx!

@3cp
Copy link
Member

3cp commented Mar 31, 2022

Released v4.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3cp 3cp

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bartosz-k @3cp