New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix features - dependencies - timezone - variable scope #248
Conversation
- use moment-timezone instead of tz-offset in TimeMatcher Class - add apply method in TimeMatcher Class - update start method in Scheduler Class (apply the new TimeMatcher method) - fix Europe/Rome test - bad values on date and hours
Pull Request Test Coverage Report for Build 360
💛 - Coveralls |
Hey hi 👋, this repo is insufficient on timezone. If this PR solves this problem, is there any reason not to merge it? |
Hi ! 👋 Thank you for your interest to my PR (and this project of course) 🙏 I guess this project is not maintained or it takes time to find another maintainer. Check this issue #255 Moreover, my PR could be better - replace moment-timezone to another package (refer to this status on the momentjs website).
I'm waiting for news about this project to know if this project continues or not. I will update my PR if it continues, do nothing (leaves my PR like that) otherwise. |
Hi there! I'm really sorry for the delay. @flopal thanks for you PR. |
Don't worry about that @merencia, I understand! I'm glad to see you back to add a new version on this repo. |
Hi,
I use node v14.5.0 and npm 6.14.8, if I can help to debug.
This PR updates a lot of things.
dependencies. I used npm-check library to upgrade all dependencies and to fix some audit issues. see commit
6f2617b.
timezone. When I was running the npm test command, some tests failed about the timezone. I fixed it by replacing tz-offset to moment-timezone and updating some files (see the list item in commit 72a454a and change in commit 4f26623).
variable scope. I replaced all var to let or const (depend on the variable update). See commit 27e1140.
readme. As I said on 1), I changed the timezone library, so I updated the link / Text in the readme. See commits b487616 and 13f9022 (bad copy-paste in the first commit)
I ran again the npm test to check if everything is alright: all tests are passed, but the first test can be failed (or be passed) during the first iteration (depend on delay to reach the result [deamon.js]).