Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error in case of step value is NaN #227

Merged
merged 5 commits into from Mar 10, 2021
Merged

Conversation

ZimGil
Copy link
Contributor

@ZimGil ZimGil commented May 18, 2020

This should resolve #226

@coveralls
Copy link

coveralls commented May 18, 2020

Pull Request Test Coverage Report for Build 367

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 363: 0.0%
Covered Lines: 277
Relevant Lines: 277

💛 - Coveralls

@ZimGil
Copy link
Contributor Author

ZimGil commented May 18, 2020

Oh yeah, I will add a test case for this...

@ZimGil
Copy link
Contributor Author

ZimGil commented Oct 11, 2020

@node-cron Care to review?

@merencia
Copy link
Member

@ZimGil thanks for you PR and sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convertSteps function miss cases of a string as a divider
4 participants