Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear native timers on tests #856

Merged
merged 5 commits into from Aug 29, 2022

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Aug 28, 2022

This pull requests properly clears native timers on the installation of sinon/fake-timers.

@anonrig anonrig force-pushed the fix/flaky-sinon branch 2 times, most recently from 5afb862 to 16ab8b0 Compare August 28, 2022 18:41
@anonrig
Copy link
Contributor Author

anonrig commented Aug 28, 2022

image

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 93d909b into mercurius-js:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants