Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fix commit push presubmit step pushes failed screenshots #1200

Open
melink14 opened this issue Sep 12, 2022 · 0 comments
Open

Lint fix commit push presubmit step pushes failed screenshots #1200

melink14 opened this issue Sep 12, 2022 · 0 comments

Comments

@melink14
Copy link
Owner

This is because we naively add all changed files but igore failed screenshots when pushing new baselines.

Ideas:

  1. Change commit step to not add failed screenshots directory if possible. I'd ideally use an exclusion rather than an inclusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant