Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make red outlines around okurigana in kanji entries optional #1120

Open
Konstantin-Glukhov opened this issue Jul 6, 2022 · 3 comments · May be fixed by #1521
Open

Make red outlines around okurigana in kanji entries optional #1120

Konstantin-Glukhov opened this issue Jul 6, 2022 · 3 comments · May be fixed by #1521
Labels
enhancement good first issue

Comments

@Konstantin-Glukhov
Copy link

The following snapshot shows the red outlines/boxes around okurigana in kanji definition. Could you make it optional, or disable. These boxes are distracting.

image
@melink14
Copy link
Owner

melink14 commented Jul 6, 2022

Honestly, this behavior was inherited from the version that this forked and I agree that it's probably not needed as long as the color matches. Should be easy to remove from the CSS (maybe a small HTML chagne too)

I would probably play with it in Dev Tools and then make the change.

@melink14
Copy link
Owner

melink14 commented Jul 6, 2022

@all-contributors Add @Konstantin-Glukhov for ideas.

@allcontributors allcontributors bot mentioned this issue Jul 6, 2022
Merged
@allcontributors
Copy link
Contributor

@melink14

I've put up a pull request to add @Konstantin-Glukhov! 🎉

mergify bot pushed a commit that referenced this issue Jul 6, 2022
@allcontributors
docs: Add Konstantin-Glukhov as a contributor for ideas (#1121)
cdb94aa 
Add @Konstantin-Glukhov as a contributor for ideas.

This was requested by melink14 [in this comment](#1120 (comment))
@tora-pan tora-pan linked a pull request Apr 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add option to remove okurigana highlighting tora-pan/rikaikun
2 participants
@melink14 @Konstantin-Glukhov